[webkit-reviews] review granted: [Bug 79046] width of overflow:hidden blocks is wrong when their margins overlap floats : [Attachment 127854] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 79046: width of overflow:hidden blocks is wrong when their margins overlap
floats
https://bugs.webkit.org/show_bug.cgi?id=79046

Attachment 127854: Patch
https://bugs.webkit.org/attachment.cgi?id=127854&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=127854&action=review


> Source/WebCore/rendering/RenderBox.cpp:1261
> +	   LayoutUnit offsetFromLogicalTopOfRegion = region ?
region->offsetFromLogicalTopOfFirstPage() - offsetFromLogicalTopOfFirstPage :
0;

No need to test region here.

> LayoutTests/fast/block/float/centered-float-avoidance-complexity.html:69
> +  <h3>The orange stripe has 'overflow: auto', 'margin-left: auto' and
'margin-right: auto'<br> The lime stripes are floats with various width
(topmost is 0, bottommost is 150px)<br>The wrapping container has a solid
silver border.</h3>

This text is lying about the margins of the orange stripe. Might as well get it
right.