[webkit-reviews] review granted: [Bug 78324] Get rid of the LocalizationStrategy : [Attachment 127047] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 14:46:05 PST 2012


Sam Weinig <sam at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 78324: Get rid of the LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=78324

Attachment 127047: Patch
https://bugs.webkit.org/attachment.cgi?id=127047&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127047&action=review


Nice.

> Source/WebCore/ChangeLog:266
> +	   (WebCore::localizedMediaControlElementHelpText):
> +	   (WebCore::localizedMediaTimeDescription):
> +	   (WebCore::validationMessageValueMissingText):
> +	   (WebCore::validationMessageValueMissingForCheckboxText):
> +	   (WebCore::validationMessageValueMissingForFileText):
> +	   (WebCore::validationMessageValueMissingForMultipleFileText):
> +	   (WebCore::validationMessageValueMissingForRadioText):
> +	   (WebCore::validationMessageValueMissingForSelectText):
> +	   (WebCore::validationMessageTypeMismatchText):
> +	   (WebCore::validationMessageTypeMismatchForEmailText):
> +	   (WebCore::validationMessageTypeMismatchForMultipleEmailText):
> +	   (WebCore::validationMessageTypeMismatchForURLText):
> +	   (WebCore::validationMessagePatternMismatchText):
> +	   (WebCore::validationMessageTooLongText):
> +	   (WebCore::validationMessageRangeUnderflowText):
> +	   (WebCore::validationMessageRangeOverflowText):
> +	   (WebCore::validationMessageStepMismatchText):

I don't think all these are needed in the change log.


More information about the webkit-reviews mailing list