[webkit-reviews] review granted: [Bug 78677] [Qt][WK2] Clipping is broken : [Attachment 127829] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 78677: [Qt][WK2] Clipping is broken
https://bugs.webkit.org/show_bug.cgi?id=78677

Attachment 127829: Patch
https://bugs.webkit.org/attachment.cgi?id=127829&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127829&action=review


Great that you fixed the issue!

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:835
> +    for (int i = data().sharedGLData().clipStack.size() - 1; i >=0; --i) {

style... missing space. Also why do you need to intersect them using reverse
order?