[webkit-reviews] review granted: [Bug 76276] [Qt] [WK2] Get rid of the dependency to QtWidgets : [Attachment 127822] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 12:54:07 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 76276: [Qt] [WK2] Get rid of the dependency to QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=76276

Attachment 127822: proposed patch
https://bugs.webkit.org/attachment.cgi?id=127822&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127822&action=review


LGTM, but I think the code in ActivateFontsQt.cpp should be re-added before
landing.

> Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:-48
> -#endif

Don't we still need these for the layout tests for the time being? It's okay to
use Widget stuff in WTR / the bundle, since this code isn't in the library
itself.


More information about the webkit-reviews mailing list