[webkit-reviews] review granted: [Bug 75078] [GStreamer] media/W3C failures : [Attachment 127597] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 75078: [GStreamer] media/W3C failures
https://bugs.webkit.org/show_bug.cgi?id=75078

Attachment 127597: Patch
https://bugs.webkit.org/attachment.cgi?id=127597&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127597&action=review


What is the meaning of PASS "maybe" is "maybe" in the new baselines?

Please take a look at the suggestion below before landing.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:288
> +    KURL kurl(KURL(), url);
> +    String cleanUrl(url);

I think it would be better here to do:

if (kurl.isLocalFile()) {
    kurl.setQuery("");
    kurl.removeFragmentIdentifier();
}