[webkit-reviews] review denied: [Bug 78878] Adding a ShadowRoot to image-backed element causes a crash : [Attachment 127784] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied MORITA Hajime
<morrita at google.com>'s request for review:
Bug 78878: Adding a ShadowRoot to image-backed element causes a crash
https://bugs.webkit.org/show_bug.cgi?id=78878

Attachment 127784: Patch
https://bugs.webkit.org/attachment.cgi?id=127784&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127784&action=review


This patch looks awesome! There are some failures on bots, which means it's not
yet ready, but I really like the direction.

> Source/WebCore/ChangeLog:19
> +	   This change re-align the responsibility:

"re-aligns"

> Source/WebCore/ChangeLog:23
> +	     return true regardless the HTML semantics allows its node to do
that.

"regardless of HTML semantics."

> Source/WebCore/ChangeLog:34
> +	   By this change, some decision points are moved from a renderer to an


"With this change"