[webkit-reviews] review granted: [Bug 71816] [Qt] run-qtwebkit-tests doesn't consider timeouts as failures : [Attachment 127819] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 08:25:15 PST 2012


Csaba Osztrogonac <ossy at webkit.org> has granted János Badics
<dicska at gmail.com>'s request for review:
Bug 71816: [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
https://bugs.webkit.org/show_bug.cgi?id=71816

Attachment 127819: proposed patch
https://bugs.webkit.org/attachment.cgi?id=127819&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127819&action=review


LGTM, r=me with minor fixes. I'll fix them before landing.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:580
> +	       self.statusLine = "Failure: timeout occured while testing"

You missed to add "[" and "]".

> Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:147
> +	   self.assertResults(FAILURE, "API tests", """INFO:Exec:Finished
WebKitBuild/Release/Source/WebKit/qt/tests/benchmarks/painting/tst_painting

The expected result is "Failure: timeout occured while testing" instead of "API
tests".


More information about the webkit-reviews mailing list