[webkit-reviews] review requested: [Bug 78578] There is no complete test cases of optional arguments for MediaStream API and PeerConnection : [Attachment 127798] new patch

[bugzilla-daemon at webkit.org]

Yanbin <yanbin.zhang at intel.com> has asked  for review:
Bug 78578: There is no complete test cases of optional arguments for
MediaStream API and PeerConnection
https://bugs.webkit.org/show_bug.cgi?id=78578

Attachment 127798: new patch
https://bugs.webkit.org/attachment.cgi?id=127798&action=review

------- Additional Comments from Yanbin <yanbin.zhang at intel.com>

Updated patch for command #6.
For failure of command #6, because some test cases for ICE State defined at
http://www.w3.org/TR/webrtc/ were run . It seem those features don't
implemented now. 
FAIL pc.ICE_GATHERING == 0x100	should be true. Was false.
FAIL pc.ICE_WAITING == 0x200 should be true. Was false.
FAIL pc.ICE_CHECKING == 0x300 should be true. Was false.
FAIL pc.ICE_CONNECTED == 0x400 should be true. Was false.
FAIL pc.ICE_COMPLETED == 0x500 should be true. Was false.
FAIL pc.ICE_FAILED == 0x600 should be true. Was false.
FAIL pc.ICE_CLOSED == 0x700 should be true. Was false.
FAIL pc.SDP_IDLE == 0x1000 should be true. Was false.
FAIL pc.SDP_WAITING == 0x2000 should be true. Was false.
FAIL pc.SDP_GLARE ==0x3000 should be true. Was false.

test results for those test cases at peerconnection-Attributes-expected.txt
file have been modified to FAIL .