[webkit-reviews] review denied: [Bug 79008] Manage node distributions in ShadowRootList, instead of each ShadowRoots. : [Attachment 127766] update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 20 01:21:15 PST 2012


MORITA Hajime <morrita at google.com> has denied Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 79008: Manage node distributions in ShadowRootList, instead of each
ShadowRoots.
https://bugs.webkit.org/show_bug.cgi?id=79008

Attachment 127766: update
https://bugs.webkit.org/attachment.cgi?id=127766&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127766&action=review


> Source/WebCore/ChangeLog:3
> +	   Make ShadowRootList manage a node distribution.

Could you elaborate?

> Source/WebCore/dom/ShadowRoot.h:31
> +#include "Element.h"

This dependency is unfortunate. Why do we need this? It looks we can just
modify removed functions as delegates.


More information about the webkit-reviews mailing list