[webkit-reviews] review denied: [Bug 75067] [Forms] Spin buttons of number input type should fire both input and change event : [Attachment 127772] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 75067: [Forms] Spin buttons of number input type should fire both input and
change event
https://bugs.webkit.org/show_bug.cgi?id=75067

Attachment 127772: Patch 1
https://bugs.webkit.org/attachment.cgi?id=127772&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127772&action=review


> Source/WebCore/html/TextFieldInputType.cpp:113
> +    case DispatchInputAndChangeEvent:
> +	   element()->dispatchFormControlInputEvent();
> +	   element()->dispatchFormControlChangeEvent();
> +	   break;
> +

dispatchFormControlInputEvent() executes a JavaScript event handler, and it
might change the input type, or might delete the input element. So, we can't
access any members of this and element().

You need to do:
    RefPtr<HTMLInputElement> input(element()); 
before event dispatching functions, and use 'input' instead of 'element()'
after an event dispatching functions.

> LayoutTests/fast/forms/number/spin-button-events.html:23
> +if (window.layoutTestController) {
> +  testIt();
> +}

Please show a manual test instruction if there is no layoutTestControler.