[webkit-reviews] review canceled: [Bug 79001] undo manager retains RefPtr to nodes in documents that would otherwise have been GC'ed : [Attachment 127761] proof of concept wip patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 79001: undo manager retains RefPtr to nodes in documents that would
otherwise have been GC'ed
https://bugs.webkit.org/show_bug.cgi?id=79001

Attachment 127761: proof of concept wip patch
https://bugs.webkit.org/attachment.cgi?id=127761&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
Here's my attempt to mitigate this issue. I'm removing all undo step objects
when the frame is destroyed. For Mac port, this can be done by creating targets
for each "host" document and then removing all targets when the corresponding
frame is destroyed.

I probably need to hash out the details but it compiles & loads pages as is.