[webkit-reviews] review denied: [Bug 78486] [chromium] check that we're not running multiple modal dialogs at the same time : [Attachment 127557] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied jochen at chromium.org's request for
review:
Bug 78486: [chromium] check that we're not running multiple modal dialogs at
the same time
https://bugs.webkit.org/show_bug.cgi?id=78486

Attachment 127557: Patch
https://bugs.webkit.org/attachment.cgi?id=127557&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127557&action=review


> Tools/DumpRenderTree/chromium/WebViewHost.cpp:906
> +    // This WebViewHost might get deleted before RunMessageLoop() returns,
so keep a copy of the m_shell member variable around.
> +    TestShell* shell = m_shell;
>      webkit_support::RunMessageLoop();
>      webkit_support::MessageLoopSetNestableTasksAllowed(oldState);
> +    shell->setIsDisplayingModalDialog(false);

When the WebViewHost is deleted, the TestShell is also deleted.