[webkit-reviews] review denied: [Bug 72010] Support for Vibration API : [Attachment 127696] Patch (Adopt Bug 78085 style).

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 72010: Support for Vibration API
https://bugs.webkit.org/show_bug.cgi?id=72010

Attachment 127696: Patch (Adopt Bug 78085 style).
https://bugs.webkit.org/attachment.cgi?id=127696&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127696&action=review


Considering that the API is now dynamically configurable,
I think it's OK to enable this for at least one port. (It would be EFL.)
It will greatly help this code being part of the tree greenness.

> Source/WebCore/Modules/vibration/NavigatorVibration.cpp:57
> +    Vibration::from(navigator->frame()->page())->vibrate(time);

Please don't rely on the fact that the Vibrator object being provided and check
the NULL case.
That will allow us to ENABLE this safely without providing the Vibrator object
from the API layer, and make it easy to keep this option ENABLE-d.

> Source/WebCore/Modules/vibration/NavigatorVibration.cpp:75
> +    Vibration::from(navigator->frame()->page())->vibrate(pattern);

Ditto.