[webkit-reviews] review granted: [Bug 78638] Don't clear IntentRequest callback pointers on stop() : [Attachment 127680] Patch

Sun Feb 19 12:39:01 PST 2012

Adam Barth <abarth at webkit.org> has granted Greg Billock <gbillock at google.com>'s
request for review:
Bug 78638: Don't clear IntentRequest callback pointers on stop()
https://bugs.webkit.org/show_bug.cgi?id=78638

Attachment 127680: Patch
https://bugs.webkit.org/attachment.cgi?id=127680&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127680&action=review

> Source/WebCore/ChangeLog:-3004
> ->>>>>>> .r108008

This change looks spurious.

> LayoutTests/webintents/resources/web-intents-reload-new.html:7
> +<html>
> +  <head>
> +  </head>
> +  <body>
> +    <p>No crash is pass.</p>
> +  </body>
> +</html>

You can also just call this "pass.html" and just have the text PASS (so it can
be reused by other tests).

> LayoutTests/webintents/resources/web-intents-reload-orig.html:23
> +	   // This should not crash.
> +	   window.location = "resources/web-intents-reload-new.html";

Are you use this shouldn't be "web-intents-reload-new.html" ?  The URL should
be relative to this document.