[webkit-reviews] review requested: [Bug 78684] Layout issue with fieldset legend element : [Attachment 127691] Attachment showing actual output

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 20:41:39 PST 2012


SravanKumar S <ssandela at innominds.com> has asked  for review:
Bug 78684: Layout issue with fieldset legend element
https://bugs.webkit.org/show_bug.cgi?id=78684

Attachment 127691: Attachment showing actual output
https://bugs.webkit.org/attachment.cgi?id=127691&action=review

------- Additional Comments from SravanKumar S <ssandela at innominds.com>
Hi,

I executed these failing tests(pixel tests) on win-7 and the first test is
passing, but the second test(fast/block/basic/fieldset-stretch-to-legend.html)
is failing with 0.61% of difference in images. How ever Following are my
observations on both the test results, 

1. The difference is "actual image"(Attached actual image rendered through win
launcher) has full border, where as the expected image has little clipped
regions when ever the "legend" element touches left or right borders of
fieldset.

2. I checked this behavior on all major browsers and only Chrome&Safari browser
seems to be clipping the left and right borders.

3. Also, there is no specification saying that left and right borders should be
clipped like the way Chrome&Safari browsers are doing right now.

So, i feel the present patch is also fixing these two tests and they need to be
re-baselined, based on above data.


More information about the webkit-reviews mailing list