[webkit-reviews] review granted: [Bug 78860] Frame and Navigator shouldn't need to worry about Geolocation : [Attachment 127662] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 78860: Frame and Navigator shouldn't need to worry about Geolocation
https://bugs.webkit.org/show_bug.cgi?id=78860

Attachment 127662: Patch
https://bugs.webkit.org/attachment.cgi?id=127662&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127662&action=review


> Source/WebCore/page/Page.cpp:207
> +	   frame->willDetachPage();
> +	   frame->detachFromPage();

Makes one wonder if detachFromPage should call willDetachPage()...