[webkit-reviews] review granted: [Bug 78868] Move textDirectionForSelection from Editor to EditingStyle : [Attachment 127499] Patch

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 78868: Move textDirectionForSelection from Editor to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=78868

Attachment 127499: Patch
https://bugs.webkit.org/attachment.cgi?id=127499&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127499&action=review


Looks good to me. Please make sure you don't check in the changes to the
project. File.

> Source/WebCore/ChangeLog:11
> +	   * WebCore.xcodeproj/project.pbxproj:

This should be removed

> Source/WebCore/ChangeLog:16
> +	   (EditingStyle):

I normally remove these lines, since they don't add any valuable information.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:7388
> +		1C435CD514E8545B004E10EA /* Inspector-1.0.json */ = {isa =
PBXFileReference; lastKnownFileType = text; path = "Inspector-1.0.json";
sourceTree = "<group>"; };

I don't think this is part of this patch.