[webkit-reviews] review granted: [Bug 78852] Add FractionalLayoutSize for sub-pixel layout : [Attachment 127617] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 12:01:23 PST 2012


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 78852: Add FractionalLayoutSize for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=78852

Attachment 127617: Patch
https://bugs.webkit.org/attachment.cgi?id=127617&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127617&action=review


> Source/WebCore/platform/graphics/FractionalLayoutSize.h:70
> +	   m_width = static_cast<int>(static_cast<float>(m_width) * scale);
> +	   m_height = static_cast<int>(static_cast<float>(m_height) * scale);

I'm surprised you need the statis_cast<float>.	Wont float * int return a float
anyway?


More information about the webkit-reviews mailing list