[webkit-reviews] review granted: [Bug 78911] Fix some warnings encountered during the GTK+ build : [Attachment 127607] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 10:37:03 PST 2012


Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 78911: Fix some warnings encountered during the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=78911

Attachment 127607: Patch
https://bugs.webkit.org/attachment.cgi?id=127607&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127607&action=review


> Source/WebCore/page/GestureTapHighlighter.cpp:182
> +	   LayoutRect next = i != (drawableRects.size() - 1) ?
drawableRects.at(i + 1) : LayoutRect();

I think < fits better the spirit of this code, tbh. So, i < (drawableRects.size
- 1).


More information about the webkit-reviews mailing list