[webkit-reviews] review granted: [Bug 78805] [GTK] Allow printing multiple copies in WebKit2 for printers that don't support it : [Attachment 127367] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 78805: [GTK] Allow printing multiple copies in WebKit2 for printers that
don't support it
https://bugs.webkit.org/show_bug.cgi?id=78805

Attachment 127367: Patch
https://bugs.webkit.org/attachment.cgi?id=127367&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127367&action=review


>>> Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:329
>>> +		     collated = 0;
>> 
>> This puzzled me. Why do you set collated to 0 in this case? Is it so that if
there are uncollated copies left the count will start from scratch?
> 
> No, there can't be collated and uncollated at the same time, they are
mutually exclusive. When collatedCopiesLeft() is 0, it's because collated ==
collatedCopies - 1, so we reset it to 0, so that next page is collated again.

OK, makes sense