[webkit-reviews] review requested: [Bug 78389] wtf/ThreadingWin.cpp doesn't build for 64-bit Windows : [Attachment 127602] Patch v5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 09:09:14 PST 2012


Kalev Lember <kalevlember at gmail.com> has asked	for review:
Bug 78389: wtf/ThreadingWin.cpp doesn't build for 64-bit Windows
https://bugs.webkit.org/show_bug.cgi?id=78389

Attachment 127602: Patch v5
https://bugs.webkit.org/attachment.cgi?id=127602&action=review

------- Additional Comments from Kalev Lember <kalevlember at gmail.com>
Thank you for the review, Adam!

Applied all the suggested changes. The leakPtr() return value checking was only
there to silence the compiler warnings, so I'm very glad there was a cleaner
(or at least a more obvious) way to do it.

// Balanced by adoptPtr() in wtfThreadEntryPoint.
ThreadFunctionInvocation* leakedInvocation = invocation.leakPtr();
UNUSED_PARAM(leakedInvocation);


More information about the webkit-reviews mailing list