[webkit-reviews] review granted: [Bug 78895] Web Inspector: check undo-redo boundaries based on current action index, not history size. : [Attachment 127577] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 08:01:48 PST 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 78895: Web Inspector: check undo-redo boundaries based on current action
index, not history size.
https://bugs.webkit.org/show_bug.cgi?id=78895

Attachment 127577: Patch
https://bugs.webkit.org/attachment.cgi?id=127577&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127577&action=review


> Source/WebCore/inspector/InspectorHistory.cpp:93
> +    if (!action->mergeId().isEmpty() && m_afterLastActionIndex > 0 &&
m_afterLastActionIndex < m_history.size() && action->mergeId() ==
m_history[m_afterLastActionIndex - 1]->mergeId())

Please remove second condition


More information about the webkit-reviews mailing list