[webkit-reviews] review granted: [Bug 78893] [GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2 : [Attachment 127578] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 17 06:07:54 PST 2012
Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 78893: [GTK] Rename WebKitPrintOperation::done signal to ::finished in
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78893
Attachment 127578: Patch
https://bugs.webkit.org/attachment.cgi?id=127578&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127578&action=review
Looks good to me; also having an enum allows us to expand this API more easily,
though I think it'll probably not need too much change in the future after it
settles =)
> Source/WebKit2/ChangeLog:18
> + (webkitPrintOperationRunDialogWin32): Dittoo.
s/oo/o/
> Source/WebKit2/ChangeLog:20
> + (webkitPrintOperationRunDialogForFrame): Do ot emit finished if
s/ot/not/
More information about the webkit-reviews
mailing list