[webkit-reviews] review requested: [Bug 78893] [GTK] Rename WebKitPrintOperation::done signal to ::finished in WebKit2 : [Attachment 127578] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 17 05:53:37 PST 2012


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 78893: [GTK] Rename WebKitPrintOperation::done signal to ::finished in
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78893

Attachment 127578: Patch
https://bugs.webkit.org/attachment.cgi?id=127578&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
It's not emitted anynmore when the print dialog has been cancelled. Since it's
not possible to know whether the print dialog was cancelled or not, the enum
WebKitPrintOperationResponse has been added, with Print and Cancel values, and
it's used as return value of webkit_print_operation_run_dialog(). I've used an
enum instead of a boolean just in case we add
WEBKIT_PRINT_OPERATION_RESPONSE_PREVIEW in the future


More information about the webkit-reviews mailing list