[webkit-reviews] review requested: [Bug 12499] External <use> xlink:href references do not work : [Attachment 127563] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 17 02:43:52 PST 2012
Renata Hodovan <reni at webkit.org> has asked for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499
Attachment 127563: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=127563&action=review
------- Additional Comments from Renata Hodovan <reni at webkit.org>
> Why is this custom error() impl needed? CachedResource::error only contains
an additional m_data.clear() - that can't hurt, so why not leave it to the
base-class?
Right, I removed it.
Changelog is also updated. This first part contains just a minimal explanation
about the newly added classes. The functionality and its description will be in
the follow-up patch.
More information about the webkit-reviews
mailing list