[webkit-reviews] review granted: [Bug 78873] [Forms] Merge InputType::dispatchChangeEventInResponseToSetValue into call site : [Attachment 127533] Patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 16 23:51:09 PST 2012
Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 78873: [Forms] Merge InputType::dispatchChangeEventInResponseToSetValue
into call site
https://bugs.webkit.org/show_bug.cgi?id=78873
Attachment 127533: Patch 1
https://bugs.webkit.org/attachment.cgi?id=127533&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127533&action=review
Looks ok.
> Source/WebCore/html/TextFieldInputType.cpp:94
> + if (valueChanged) {
nit: We prefer early exit:
if (!valueChanged)
return;
More information about the webkit-reviews
mailing list