[webkit-reviews] review denied: [Bug 78876] Fine-grained JSC JIT code profiling at the function level : [Attachment 127520] proposed patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has denied Yuqiang Xian
<yuqiang.xian at intel.com>'s request for review:
Bug 78876: Fine-grained JSC JIT code profiling at the function level
https://bugs.webkit.org/show_bug.cgi?id=78876

Attachment 127520: proposed patch
https://bugs.webkit.org/attachment.cgi?id=127520&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I think there is a problem with this in that the string concatenation may
trigger a malloc, and the main thread may be suspended holding the malloc heap
lock, resulting in deadlock.
I do think we'll want to get more detailed information out of the profiler, but
I'm not sure this is the right approach – rather, I think we may want a way to
retain all code blocks while profiling, and to lazily manage mapping sampled
PCs back to the byte code offset (line number, etc), from the main thread once
sampling is complete.