[webkit-reviews] review denied: [Bug 77931] Element should be able to have multiple shadow roots. : [Attachment 127493] Patch

[bugzilla-daemon at webkit.org]

MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 77931: Element should be able to have multiple shadow roots.
https://bugs.webkit.org/show_bug.cgi?id=77931

Attachment 127493: Patch
https://bugs.webkit.org/attachment.cgi?id=127493&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127493&action=review


I think we should land rendering related changes at the same time even if the
patch will be bigger.
Without rendering, I cannot see if the patch is correct or not.

> LayoutTests/fast/dom/shadow/multiple-shadowroot.html:21
> +shouldBe("internals.address(internals.shadowRoot(div))",
"internals.address(shadowRoot1)");

We should make "===" work for ShadowRoot instances instead of relying
address(). Having address() on Internals object is OK because it's useful for
trouble shooting.
But I don't think use it for testing is good idea.