[webkit-reviews] review denied: [Bug 78796] [Refactoring] Remove location from NodeRenderingContext. : [Attachment 127477] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 17:29:14 PST 2012


MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 78796: [Refactoring] Remove location  from NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=78796

Attachment 127477: Patch
https://bugs.webkit.org/attachment.cgi?id=127477&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127477&action=review


basically looks good. Let's take small time to make the intention clear.

> Source/WebCore/dom/NodeRenderingContext.h:79
>      };

It's time to give good name for these phase.
Could you pick some relevant word from the Shadow DOM node composition
algorithm?


More information about the webkit-reviews mailing list