[webkit-reviews] review denied: [Bug 63383] Don't check dangling icon database urls in release build if not pruning entries. : [Attachment 98597] Dangling fix

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Lukasz Slachciak
<l.slachciak at samsung.com>'s request for review:
Bug 63383: Don't check dangling icon database urls in release build if not
pruning entries.
https://bugs.webkit.org/show_bug.cgi?id=63383

Attachment 98597: Dangling fix
https://bugs.webkit.org/attachment.cgi?id=98597&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This patch doesn't make things correct.  The code changed in this patch does
indeed follow what the comment says.

The real fix is in the if statement:

if ((pruneIfFound || !danglersFound) && SQLiteStatement(m_syncDB, "SELECT url
FROM PageURL WHERE PageURL.iconID NOT IN (SELECT iconID FROM IconInfo) LIMIT
1;").returnsAtLeastOneResult())
should become...
if (pruneIfFound && (danglersFound || SQLiteStatement(m_syncDB, "SELECT url
FROM PageURL WHERE PageURL.iconID NOT IN (SELECT iconID FROM IconInfo) LIMIT
1;").returnsAtLeastOneResult()))