[webkit-reviews] review denied: [Bug 78713] Absolute positioned elements with Inline Relative Positioned Container are not layout correctly : [Attachment 127186] proposed patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has denied Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 78713: Absolute positioned elements with Inline Relative Positioned
Container are not layout correctly
https://bugs.webkit.org/show_bug.cgi?id=78713

Attachment 127186: proposed patch
https://bugs.webkit.org/attachment.cgi?id=127186&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127186&action=review


This is the wrong fix. RenderObject::container() should be patched not
markContainingBlockForLayout().

The right fix (TM) is to find a way to merge container() and containingBlock()
so that such bugs don't happen down the road again.

> Source/WebCore/ChangeLog:12
> +	   This is a regression. r104183 changes containingBlock() so that it
returns the container
> +	   of an anonymous block for positioned objects, not the anonymous
block itself. We should
> +	   change markContainingBlocksForLayout() to match the change in
containingBlock().

Your analysis is good but the conclusion is wrong. container() and
containingBlock() should return the same result and here they don't.