[webkit-reviews] review granted: [Bug 75253] [GTK] Implement zoom in/out in MiniBrowser : [Attachment 120585] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 75253: [GTK] Implement zoom in/out in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75253

Attachment 120585: Patch
https://bugs.webkit.org/attachment.cgi?id=120585&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120585&action=review


Looks good. This doesn't depend on the decision in bug 75249, so I'll r+

> Tools/MiniBrowser/gtk/BrowserWindow.c:186
> +    return zoomLevel <= maximumZoomLevel;

I guess this should be zoomLevel < maximumZoomLevel, otherwise you would be
reporting you can zoom in while being at the maximum zoom level.

> Tools/MiniBrowser/gtk/BrowserWindow.c:192
> +    return zoomLevel >= minimumZoomLevel;

Same here.