[webkit-reviews] review granted: [Bug 67660] [GTK] Add a way to expose well known names for items in the default context menu : [Attachment 106760] Patch removing need for const_cast

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 67660: [GTK] Add a way to expose well known names for items in the default
context menu
https://bugs.webkit.org/show_bug.cgi?id=67660

Attachment 106760: Patch removing need for const_cast
https://bugs.webkit.org/attachment.cgi?id=106760&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=106760&action=review


Looks good! Let's do something like this for WebKit2 as well.

> Source/WebKit/gtk/tests/testcontextmenu.c:36
> +static TestInfo* testInfoNew(const char* data, guint flag)

Many of the asterisks are in the wrong place in this file. Can you just fix all
those before landing?

> Source/WebKit/gtk/tests/testcontextmenu.c:40
> +    TestInfo* info;
> +
> +    info = g_slice_new(TestInfo);

Collapse this into one line.

> Source/WebKit/gtk/tests/testcontextmenu.c:102
> +    guint context;
> +    GList* items;
> +    GList* iter;

I would just define these where you first use them.

> Source/WebKit/gtk/tests/testcontextmenu.c:133
> +	   break;
> +
> +    case WEBKIT_HIT_TEST_RESULT_CONTEXT_EDITABLE:

Extra newline here?