[webkit-reviews] review denied: [Bug 16123] [GTK] Smooth scrolling support : [Attachment 102527] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 16123: [GTK] Smooth scrolling support
https://bugs.webkit.org/show_bug.cgi?id=16123

Attachment 102527: Patch
https://bugs.webkit.org/attachment.cgi?id=102527&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=102527&action=review


Looks good! Is there any compelling reason to make this a compile-time option?
Why not just compile it in always. r- because of the missing documentation. We
need one more GTK+ reviewer to approve the API, but I think it's pretty
non-controversial. Do you think you could add the setting to WebKit2 as well?

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:932
> +    * Whether ...

You're missing the documentation here. :(