[webkit-reviews] review denied: [Bug 76362] ASSERT_ICON_SYNC_THREAD fired in WebCore::IconDatabase::iconDatabaseSyncThread() : [Attachment 122590] patch to check for syncthread in open

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 13:32:48 PST 2012


Eric Seidel <eric at webkit.org> has denied MORITA Hajime <morrita at google.com>'s
request for review:
Bug 76362: ASSERT_ICON_SYNC_THREAD fired in
WebCore::IconDatabase::iconDatabaseSyncThread()
https://bugs.webkit.org/show_bug.cgi?id=76362

Attachment 122590: patch to check for syncthread  in open
https://bugs.webkit.org/attachment.cgi?id=122590&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122590&action=review


> Source/WebCore/ChangeLog:7
> +	   No new tests. (OOPS!)

This line will cause the commit-queue to fail.	It should be replaced by an
explanation of why LayoutTesting is impractiacal for this change.  Sometimes it
is OK to not have tests, but we have to explain in the changelog.


More information about the webkit-reviews mailing list