[webkit-reviews] review granted: [Bug 78509] [BlackBerry] Upstream touch handling related classes : [Attachment 127418] patch_2/3 v3 - FatFingers

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 78509: [BlackBerry] Upstream touch handling related classes
https://bugs.webkit.org/show_bug.cgi?id=78509

Attachment 127418: patch_2/3 v3 - FatFingers
https://bugs.webkit.org/attachment.cgi?id=127418&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127418&action=review


Looks good.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:44
> +#include "WebPage_p.h"

Is this minimal?

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:54
> +using WTF::String;

Probably not needed.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:315
> +    // Iterate over the list of nodes (and subrects of nodes where
possible), for each saving the intersection of the bounding box with the finger
rect

Lacks period.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:416
> +	   // Iterate through all words, breaking at whitespace, to find the
bounding box of each word

Lacks period.