[webkit-reviews] review denied: [Bug 78459] [Chromium] [WebSocket] provide a path to bind WebFrameClient and SocketStreamHandle : [Attachment 127126] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Takashi Toyoshima
<toyoshim at chromium.org>'s request for review:
Bug 78459: [Chromium] [WebSocket] provide a path to bind WebFrameClient and
SocketStreamHandle
https://bugs.webkit.org/show_bug.cgi?id=78459

Attachment 127126: Patch
https://bugs.webkit.org/attachment.cgi?id=127126&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127126&action=review


> Source/WebKit/chromium/public/platform/WebSocketStreamHandle.h:55
> +    // Set requestor ID binded to RenderView.

nit: RenderView in the WebKit tree means something totally different.  See
WebCore::RenderView.
It is really best to avoid mentioning Chrome-isms for this reason.

Can you please implement this using the ExtraData approach instead?  I know it
is more work,
but we have a pending cleanup work item to remove WebURLRequest::requestorID. 
The issue here
is that we don't want to pollute WebKit with things that really don't concern
it.  requestorID
is a good example of that.