[webkit-reviews] review granted: [Bug 78315] REGRESSION(99539): Infinite repaint loop with SVGImage and deferred repaint timers : [Attachment 127403] patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 78315: REGRESSION(99539): Infinite repaint loop with SVGImage and deferred
repaint timers
https://bugs.webkit.org/show_bug.cgi?id=78315

Attachment 127403: patch
https://bugs.webkit.org/attachment.cgi?id=127403&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127403&action=review


r=me, but please add null-checks first.

> Source/WebCore/svg/graphics/SVGImage.cpp:260
> +    return m_page->mainFrame()->view();

You should check for a null m_page,, as hasRelativeWidth etc. does.

> Source/WebCore/svg/graphics/SVGImage.h:57
> +    FrameView* frameView();

Should be const, no?

> Source/WebCore/svg/graphics/SVGImageCache.cpp:87
> +    if (m_svgImage->frameView()->needsLayout() && !m_redrawTimer.isActive())


This needs a null-check as well, m_page could be null, if not, you'l need
assertions.