[webkit-reviews] review granted: [Bug 78181] nrwt: simplify worker interface : [Attachment 127314] fix indentation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 10:21:30 PST 2012


Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 78181: nrwt: simplify worker interface
https://bugs.webkit.org/show_bug.cgi?id=78181

Attachment 127314: fix indentation
https://bugs.webkit.org/attachment.cgi?id=127314&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
Should you remove duplicate methods in _TestWorker?

Since there's only one real Worker implementation, it's impossible to tell what
should be shared and what shouldn't be shared.	There's nothing wrong with this
code change, but I can't evaluate if it's better or worse than before.


More information about the webkit-reviews mailing list