[webkit-reviews] review granted: [Bug 69444] The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes. : [Attachment 127305] make the tests pass

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 69444: The new run-webkit-tests needs to dump out pixel hash failures even
if the pixel test passes.
https://bugs.webkit.org/show_bug.cgi?id=69444

Attachment 127305: make the tests pass
https://bugs.webkit.org/attachment.cgi?id=127305&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127305&action=review


We should just match old-run-webkit-tests behavior, which is to log to the
console.

> Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:270
> +		   _log.warning('%s had mismatched checksums but matching
images (exp %s, got %s)' %
> +			       (self._test_name,
expected_driver_output.image_hash, driver_output.image_hash))

Can we match ORWT's text?  If not, we should at least include the image diff
percent.