[webkit-reviews] review granted: [Bug 78822] [Texmap] Improve the way we deal with BGRA extension : [Attachment 127384] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 16 08:38:35 PST 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 78822: [Texmap] Improve the way we deal with BGRA extension
https://bugs.webkit.org/show_bug.cgi?id=78822

Attachment 127384: Patch
https://bugs.webkit.org/attachment.cgi?id=127384&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127384&action=review


r=me but please fix the minor issues

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:638
> +    return (availableExtensions.contains(extension));

why the extra ()s?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:640
> +static bool hasBgraExtension()

BGRA* this is webkit style not Qt :-)


More information about the webkit-reviews mailing list