[webkit-reviews] review granted: [Bug 76448] [GTK] Add WebKitPrintOperation to WebKit2 GTK+ API : [Attachment 126944] Fix gtk-doc warnings

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 76448: [GTK] Add WebKitPrintOperation to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76448

Attachment 126944: Fix gtk-doc warnings
https://bugs.webkit.org/attachment.cgi?id=126944&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126944&action=review


> Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:86
> +    priv->webViewDestroyedId = g_signal_connect(priv->webView, "destroy",
G_CALLBACK(webViewDestroyed), printOperation);

Do you think it would be slightly cleaner to use a weak reference here? Not a
big deal either way.

> Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:248
> +	   if (gtk_widget_is_toplevel(toplevel) && GTK_IS_WINDOW(toplevel))
> +	       parent = GTK_WINDOW(toplevel);

Would it make sense to use the new helper here?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:665
> +	* You can connect to this signal and return %TRUE to cancel the print
operation.

Might want to add "or implement your own print dialog"