[webkit-reviews] review denied: [Bug 78780] Web Inspector: move style disable checkboxes to the left : [Attachment 127363] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 78780: Web Inspector: move style disable checkboxes to the left
https://bugs.webkit.org/show_bug.cgi?id=78780

Attachment 127363: Patch
https://bugs.webkit.org/attachment.cgi?id=127363&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127363&action=review


Please add some space between checkbox and style.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1770
> -	   if (enabledCheckboxElement && this.treeOutline.section &&
this.treeOutline.section.editable && this.parent.root)

Isn't that breaking computed style? r- for that.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-1935
> -	   this.hasChildren = false;

Please keep lying.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:-2092
> -	   this.hasChildren = context.hasChildren;

ditto.