[webkit-reviews] review granted: [Bug 78496] Web Inspector: [heap snapshot] It could be useful to have access to the selected heap object from the console. : [Attachment 127212] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 78496: Web Inspector: [heap snapshot] It could be useful to have access to
the selected heap object from the console.
https://bugs.webkit.org/show_bug.cgi?id=78496

Attachment 127212: Patch
https://bugs.webkit.org/attachment.cgi?id=127212&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127212&action=review


> Source/WebCore/ChangeLog:51
> +2012-02-15  Ilya Tikhonovsky  <loislo at chromium.org>

Please remove duplicate entry.

> Source/WebCore/inspector/InspectorConsoleAgent.cpp:289
> +	   return ScriptProfiler::objectByHeapObjectId(m_heapObjectId);

I think we need to reject objects from a different ScriptState here and when
wrapping DOM Nodes. This can be done in a separate patch.