[webkit-reviews] review canceled: [Bug 19681] borderColor on table elements should be ignored : [Attachment 126947] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 16 03:35:39 PST 2012
KishoreGanesh <kbolisetty at innominds.com> has canceled KishoreGanesh
<kbolisetty at innominds.com>'s request for review:
Bug 19681: borderColor on table elements should be ignored
https://bugs.webkit.org/show_bug.cgi?id=19681
Attachment 126947: Patch
https://bugs.webkit.org/attachment.cgi?id=126947&action=review
------- Additional Comments from KishoreGanesh <kbolisetty at innominds.com>
Fix to ignore borderColor attribute of table when its border attribute is not
specified.
The contains the following updates.
1. Incorporated review comments from Robert Hogan and Julien chaffraix.
2. Modified test case to avoid pixel testing using getComputedStyle() and
detailed change log that includes comparison with FF
3. Implemented test case without using
layoutTestController.waitUntillDone/notifyDone() , because the test doesn’t
depends on any other event expect load. And by default DRT waits till load
event.
More information about the webkit-reviews
mailing list