[webkit-reviews] review granted: [Bug 78774] Fix the broken viewport tests : [Attachment 127308] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 78774: Fix the broken viewport tests
https://bugs.webkit.org/show_bug.cgi?id=78774

Attachment 127308: Patch
https://bugs.webkit.org/attachment.cgi?id=127308&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127308&action=review


> Source/JavaScriptCore/wtf/text/WTFString.h:90
> +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const LChar*, size_t,
bool* ok = 0, bool* didReadNumber = 0);

Maybe charactersToFloatIgnoringJunk would be more descriptive?

> Source/JavaScriptCore/wtf/text/WTFString.h:92
>  WTF_EXPORT_PRIVATE float charactersToFloat(const UChar*, size_t, bool* ok =
0, bool* didReadNumber = 0);
> +WTF_EXPORT_PRIVATE float charactersToFloatWithJunk(const UChar*, size_t,
bool* ok = 0, bool* didReadNumber = 0);

Btw, does the didReadNumber make sense for the non-junk versions?