[webkit-reviews] review granted: [Bug 30416] dataTransfer.types (HTML5 drag & drop) should return DOMStringList : [Attachment 127287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 15 20:31:07 PST 2012


Eric Seidel <eric at webkit.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 30416: dataTransfer.types (HTML5 drag & drop) should return DOMStringList
https://bugs.webkit.org/show_bug.cgi?id=30416

Attachment 127287: Patch
https://bugs.webkit.org/attachment.cgi?id=127287&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127287&action=review


LGTM.  Thanks.

> Source/WebCore/platform/chromium/ChromiumDataObject.cpp:113
> +	   for (HashSet<String>::const_iterator it = hashedResults.begin(); it
!= hashedResults.end(); ++it)
> +	     results->append(*it);

I think it would be totally OK to add a DOMStringList::fromHashSet function
which did this.  But this is also OK.


More information about the webkit-reviews mailing list