[webkit-reviews] review granted: [Bug 78767] REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages : [Attachment 127286] Patch v1 - New setting and app-specific quirk

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 78767: REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages
https://bugs.webkit.org/show_bug.cgi?id=78767

Attachment 127286: Patch v1 - New setting and app-specific quirk
https://bugs.webkit.org/attachment.cgi?id=127286&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=127286&action=review


> Source/WebCore/ChangeLog:12
> +	   (WebCore::DocumentLoader::isLoadingInAPISense): Return true if the
app needs the quirk
> +	     and there are outstanding subresource loads.

Odd spacing here.

> Source/WebCore/loader/DocumentLoader.cpp:452
> +	   if (m_frame->settings()->needsIsLoadingInAPISenseQuirk() &&
!m_subresourceLoaders.isEmpty())
> +	       return true;

Why is this not using a check from RuntimeApplicationChecks.h?

> Source/WebCore/page/Settings.h:530
> +	   void setNeedsIsLoadingInAPISenseQuirk(bool enabled) {
m_needsIsLoadingInAPISenseQuirk = enabled; }
> +	   bool needsIsLoadingInAPISenseQuirk() const { return
m_needsIsLoadingInAPISenseQuirk; }

Please add a comment indicating what this quirk is.