[webkit-reviews] review granted: [Bug 78759] REGRESSION (r107836): fast/box-shadow/spread.html and fast/writing-mode/box-shadow-*.html tests failing : [Attachment 127276] Refine checks in boxShadowShouldBeAppliedToBackground()

[bugzilla-daemon at webkit.org]

Simon Fraser (on vacation until 2-14) <simon.fraser at apple.com> has granted
mitz at webkit.org's request for review:
Bug 78759: REGRESSION (r107836): fast/box-shadow/spread.html and
fast/writing-mode/box-shadow-*.html tests failing
https://bugs.webkit.org/show_bug.cgi?id=78759

Attachment 127276: Refine checks in boxShadowShouldBeAppliedToBackground()
https://bugs.webkit.org/attachment.cgi?id=127276&action=review

------- Additional Comments from Simon Fraser (on vacation until 2-14)
<simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127276&action=review


> Source/WebCore/rendering/InlineFlowBox.cpp:1086
> +    return (!hasFillImage && !renderer()->style()->hasBorderRadius()) ||
(!prevLineBox() && !nextLineBox()) || !parent();

It's hard to understand all the conditions in this line. Perhaps an explanatory
comment would help.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:2623
> +    if (lastBackgroundLayer->image() && style()->hasBorderRadius())
> +	   return false;
> +
> +    if (inlineFlowBox &&
!inlineFlowBox->boxShadowCanBeAppliedToBackground(*lastBackgroundLayer))
> +	   return false;

Why do we only check the last fill layer?