[webkit-reviews] review requested: [Bug 67098] [GTK] introspection: fix some gtk-doc annotations : [Attachment 127282] updated patch: fix gtk-doc annotations

[bugzilla-daemon at webkit.org]

Diego Escalante Urrelo <diegoe at igalia.com> has asked  for review:
Bug 67098: [GTK] introspection: fix some gtk-doc annotations
https://bugs.webkit.org/show_bug.cgi?id=67098

Attachment 127282: updated patch: fix gtk-doc annotations
https://bugs.webkit.org/attachment.cgi?id=127282&action=review

------- Additional Comments from Diego Escalante Urrelo <diegoe at igalia.com>
Here is another patch, updated for a much more recent master.

The warnings are not life or death, but I guess it is better to shut them up.

I could not resolve this ones:

Source/WebKit/gtk/webkit/webkitversion.h:33: Warning: WebKit:
symbol='WEBKITGTK_API_VERSION': Unknown namespace for symbol
'WEBKITGTK_API_VERSION'

<unknown>:: Warning: WebKit: (ErrorQuarkFunction)network_error_quark:
context=ErrorQuarkFunction('network_error_quark') webkit_network_error_quark:
Couldn't find corresponding enumeration
<unknown>:: Warning: WebKit: (ErrorQuarkFunction)policy_error_quark:
context=ErrorQuarkFunction('policy_error_quark') webkit_policy_error_quark:
Couldn't find corresponding enumeration
<unknown>:: Warning: WebKit: (ErrorQuarkFunction)plugin_error_quark:
context=ErrorQuarkFunction('plugin_error_quark') webkit_plugin_error_quark:
Couldn't find corresponding enumeration

Source/WebKit/gtk/webkit/webkitwebframe.cpp:832: Warning: WebKit:
webkit_web_frame_get_global_context: return value: Unresolved type:
'JSGlobalContextRef'

DerivedSources/webkit/WebKitDOMCustom.h:32: Warning: WebKit:
webkit_dom_blob_slice: return value: Missing (transfer) annotation
DerivedSources/webkit/WebKitDOMEventTarget.h:62: Warning: WebKit:
webkit_dom_event_target_add_event_listener: argument handler: Missing (scope)
annotation for callback without GDestroyNotify (valid: call, async)
DerivedSources/webkit/WebKitDOMEventTarget.h:68: Warning: WebKit:
webkit_dom_event_target_remove_event_listener: argument handler: Missing
(scope) annotation for callback without GDestroyNotify (valid: call, async)